diff options
| -rw-r--r-- | TODO | 12 | ||||
| -rw-r--r-- | blabouncer.c | 6 | ||||
| -rw-r--r-- | message.c | 6 | ||||
| -rw-r--r-- | structures.h | 2 |
4 files changed, 19 insertions, 7 deletions
@@ -1 +1,13 @@ All the TODOs sprinkled throughout the code! + +Configurable rotation of replay and debug logs. + +Add a make install/uninstall/etc., add an "INSTALL" file, include a dependency listing. + +"|| LOG_MODE" should be "type == LOG_MODE" in logging.c. + +macOS compiler may need limits.h included in structures.h. + +replaymode = "lastspoke" causes huge amounts of spam from extractnickfromprefix() and friends in full debug mode. + +Very slow processing of removenickfromallchannels() when another user QUITs (sometimes). diff --git a/blabouncer.c b/blabouncer.c index 8648a49..a9eab97 100644 --- a/blabouncer.c +++ b/blabouncer.c @@ -616,7 +616,7 @@ void dochat(int *serversockfd, int *clientsockfd, struct settings *settings) { } } } else { - // No timeout is occuring, the pselect() just timed out (which is fine and expected), back to the top of the loop + // No timeout is occurring, the pselect() just timed out (which is fine and expected), back to the top of the loop continue; } } @@ -684,7 +684,7 @@ void dochat(int *serversockfd, int *clientsockfd, struct settings *settings) { debugprint(DEBUG_SOME, "BOUNCER-SERVER RECEIVED: '%s', length '%d'.\n", serverbuf, servernumbytes); // Try to process received string (which should contain one or more server responses/commands) - // TODO - What if there were two server respones/commands and only one didn't need relaying? + // TODO - What if there were two server responses/commands and only one didn't need relaying? if (!processrawstring(server_ssl, serverbuf, SOURCE_SERVER, clients, EXCEPT_NONE, &ircdstate, channels, settings, clientcodes)) { fprintf(stderr, "Error: bouncer-server failed to process raw string.\n"); debugprint(DEBUG_CRIT, "Error: bouncer-server failed to process raw string.\n"); @@ -854,7 +854,7 @@ void dochat(int *serversockfd, int *clientsockfd, struct settings *settings) { debugprint(DEBUG_SOME, "BOUNCER-CLIENT RECEIVED: '%s'\n", clientbuf); // Try to process received string (which should contain one or more client responses/commands) - // TODO - What if there were two server respones/commands and only one didn't need relaying? + // TODO - What if there were two client responses/commands and only one didn't need relaying? if (!processrawstring(server_ssl, clientbuf, SOURCE_CLIENT, clients, i, &ircdstate, channels, settings, clientcodes)) { fprintf(stderr, "Error: bouncer-client failed to process raw string.\n"); debugprint(DEBUG_CRIT, "Error: bouncer-client failed to process raw string.\n"); @@ -1297,7 +1297,7 @@ int processclientmessage(SSL *server_ssl, char *str, struct client *clients, int // Make sure we don't have more than three (d:h:m) components if (timecounter > 3) { debugprint(DEBUG_SOME, "Too many time components requested by REPLAY command. Telling client.\n"); - snprintf(outgoingmsg, MAXDATASIZE, "NOTICE %s :Too many time components requestd by REPLAY command. Expected up to three (days:hours:minutes).", ircdstate->ircnick); + snprintf(outgoingmsg, MAXDATASIZE, "NOTICE %s :Too many time components requested by REPLAY command. Expected up to three (days:hours:minutes).", ircdstate->ircnick); sendtoclient(sourcefd, outgoingmsg, clients, settings, 0); free(timestrcopyPtr); return 1; @@ -1399,8 +1399,8 @@ int processclientmessage(SSL *server_ssl, char *str, struct client *clients, int // Make sure the client code length is good if (strlen(tokens[2]) < 1 || strlen(tokens[2]) > CLIENTCODELEN - 1) { - debugprint(DEBUG_SOME, "Invalid CLIENTODE length.\n"); - snprintf(outgoingmsg, MAXDATASIZE, "NOTICE %s :Invalid CLIENTODE length. Must be 1 to %d characters.", ircdstate->ircnick, CLIENTCODELEN - 1); + debugprint(DEBUG_SOME, "Invalid CLIENTCODE length.\n"); + snprintf(outgoingmsg, MAXDATASIZE, "NOTICE %s :Invalid CLIENTCODE length. Must be 1 to %d characters.", ircdstate->ircnick, CLIENTCODELEN - 1); sendtoclient(sourcefd, outgoingmsg, clients, settings, 0); return 1; } diff --git a/structures.h b/structures.h index 02b13b8..0fbebff 100644 --- a/structures.h +++ b/structures.h @@ -84,7 +84,7 @@ struct settings { int replaydates; // Whether or not to include datestamps when replaying the replay log }; -// Structure of a connected clien, their socket/file descriptors, their authentication status, and their OpenSSL structures +// Structure of a connected client, their socket/file descriptors, their authentication status, and their OpenSSL structures // This struct is expected to be in an array of client structs struct client { int fd; // Client socket fd - 0 means not connected, greater than 0 means connected and the value is the fd number (so we know which ones to try to read and send to) |