summaryrefslogtreecommitdiff
path: root/README.md
diff options
context:
space:
mode:
authorFbenas <philbeansburton@gmail.com>2018-05-07 16:47:13 +0100
committerFbenas <philbeansburton@gmail.com>2018-05-07 16:47:13 +0100
commit55acf626c2e62144984e83b42db49b298a9e2938 (patch)
treebb5143a56905dfb77ba6388057a0307abd31f790 /README.md
parent06fd79055b1e9f850a51b68523114d3ded5ee26c (diff)
Add unit tests and amend unit test part in readmeHEADmaster
Diffstat (limited to 'README.md')
-rw-r--r--README.md7
1 files changed, 7 insertions, 0 deletions
diff --git a/README.md b/README.md
index 97456b8..be2b6b8 100644
--- a/README.md
+++ b/README.md
@@ -24,6 +24,12 @@ Example:
```
php scripts/run.php -fdata/input.txt -c150 -lEC123 -t12:00 -d09/05/18
```
+
+To run unit tests:
+```
+php ./vendor/bin/phpunit tests
+```
+
# Design Decisions
## Coding style and standards
@@ -63,3 +69,4 @@ The filtering is tightly coupled with both the `App\Model\Collection` and the `A
# Testing
I have not attempted to get full coverage of the code, and I have not attempted to cover all the possible use cases for input.
I have added these unit tests, using PHPUnit to show that I am capable of writing testable code and writing unit tests to cover that code.
+Because of time constraints I have left this part a little light. Usually I would prefer to make a base test class, or many base test classes for similar objects and have many more tests for each component. I happy to discuss more about how I would enhance these unit tests and the main project code in-order to get better test coverage.