summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLuke Bratch <luke@bratch.co.uk>2019-05-20 18:13:20 +0100
committerLuke Bratch <luke@bratch.co.uk>2019-05-20 18:13:20 +0100
commit954aafdf50559dc9f868f79aacbdfdb0bf8bbb3b (patch)
tree4dce9f0e0a00887272ecae77653c3606d6b25da3
parent18775b0ae37edc1a5906df006f0e0e5f7da66afe (diff)
Fix memory leak when updating nick when server sends NICK.
-rw-r--r--TODO15
-rw-r--r--blabouncer.c1
2 files changed, 16 insertions, 0 deletions
diff --git a/TODO b/TODO
index cac69bf..c9d3974 100644
--- a/TODO
+++ b/TODO
@@ -14,3 +14,18 @@ Allow log replay time to be specified with days:hours:minutes:seconds.
Allow connecting to a passworded server.
Might need to #include <limits.h> in blabouncer.c to make some operating systems and/or compilers happy.
+
+Can't update greeting if server changed our nick (e.g. nick protection), then we tried to change it back, but it was now in use (e.g. by services enforcer), so our 433 handling tries to change it again.
+Maybe only do 433 handling if we're not registered yet?
+(Might be fixed by adding missing free() to fix memory leak in this commit - need to re-test.)
+
+If ChanServ gives us +q upon and then +o upon JOINing a channel, we only see +o if we are connected to blabouncer. If (re)connecting, we see a strange ~@nick status.
+Also don't seem to be able to set -q from blabouncer.
+
+Support autojoining passwords channels.
+
+Test CTCP.
+
+VSZ shows as ~2 TiB in ps:
+USER PID %CPU %MEM VSZ RSS TTY STAT START TIME COMMAND
+test123 7218 0.0 0.8 21474910660 32744 pts/22 S+ May19 0:00 ./blabouncer
diff --git a/blabouncer.c b/blabouncer.c
index 3198026..23d5217 100644
--- a/blabouncer.c
+++ b/blabouncer.c
@@ -961,6 +961,7 @@ int processircmessage(SSL *server_ssl, char *str, int source, struct client *cli
strcpy(ircdstrings->ircnick, prefixcopy);
printf("Updated ircnick to '%s'.\n", ircdstrings->ircnick);
free(nickuserhostcpy);
+ free(prefixcopy);
}
// Relay to all clients